Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 )
Change subject: IMPALA-6595: fix crash in NljBuilder::Close() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9493/1/be/src/exec/blocking-join-node.cc File be/src/exec/blocking-join-node.cc: http://gerrit.cloudera.org:8080/#/c/9493/1/be/src/exec/blocking-join-node.cc@172 PS1, Line 172: state->resource_pool()->ReleaseThreadToken(false); If the status is non-OK do we release the thread token twice? In ProcessBuildInputAndOpenProbe() we also release a thread token if status is non-OK. -- To view, visit http://gerrit.cloudera.org:8080/9493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie46b87a4889d7cee907124796c830db41125cf15 Gerrit-Change-Number: 9493 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Mar 2018 19:51:25 +0000 Gerrit-HasComments: Yes
