Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9493 to look at the new patch set (#2). Change subject: IMPALA-6595: fix crash in NljBuilder::Close() ...................................................................... IMPALA-6595: fix crash in NljBuilder::Close() The bug is that the right child of a blocking join node could be closed before the builder if an error was encountered when sending a batch to the sink. This hits a DCHECK because Buffers owned by the sink may still be accounted against the child node. Testing: Added the test that originally triggered the problem. It reproduced the failure when based on the IMPALA-4835 patch, but I can't reproduce the failure after rebase onto master. Change-Id: Ie46b87a4889d7cee907124796c830db41125cf15 --- M be/src/exec/blocking-join-node.cc M be/src/exec/data-sink.h M be/src/exec/exec-node.h M be/src/exec/nested-loop-join-node.cc M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj-exhaustive.test 5 files changed, 23 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9493/2 -- To view, visit http://gerrit.cloudera.org:8080/9493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie46b87a4889d7cee907124796c830db41125cf15 Gerrit-Change-Number: 9493 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com>