Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 )
Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/6/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/9300/6/be/src/common/init.cc@240 PS6, Line 240: signal(SIGPIPE, SIG_IGN); > I looked at the breakpad patch and don't understand it. SIGPIPE is only for Indeed it looks like the read() call wouldn't receive a SIGPIPE but instead return 0, leading to the minidump generation to continue (and ultimately fail). Blocking SIGPIPE should not interfere with it. -- To view, visit http://gerrit.cloudera.org:8080/9300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6 Gerrit-Change-Number: 9300 Gerrit-PatchSet: 6 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Mar 2018 21:29:30 +0000 Gerrit-HasComments: Yes
