Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 )
Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.h@323 PS7, Line 323: TLSv1_0 > To not change behavior, let's use the equivalent of TLSv1_0_plus from our o Done http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@77 PS7, Line 77: {"latest", LATEST}} > Where is this specified? Or is this a new option that we're trying to expos Removed. Thrift added this enum and I was not sure whether it should be here. Should we change the definition of ssl_minimum_version, because, I assume, there isn't xxx_plus anymore? http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@97 PS7, Line 97: return protocol != SSLv3 && protocol == TLSv1_0; > return protocol == SSLTLS || protocol == TLSv1_0; Done http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@99 PS7, Line 99: return protocol != SSLv3 && protocol != TLSv1_2; > return protocol == SSLTLS || protocol == TLSv1_1 && protocol != TLSv1_2; Shouldn't this be protocol == SSLTLS || protocol == TLSv1_0 || protocol != TLSv1_1? -- To view, visit http://gerrit.cloudera.org:8080/9300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6 Gerrit-Change-Number: 9300 Gerrit-PatchSet: 7 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 02:42:25 +0000 Gerrit-HasComments: Yes
