Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 )
Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/9578/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9578/1//COMMIT_MSG@8 PS1, Line 8: Could you add a little more color here, eg. "This patch enables pushing scan predicates on DECIMAL columns down to Kudu. Testing: ..." http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test: http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test@553 PS1, Line 553: # Decimal InList predicate. There's an existing test in 'PlannerTest/kudu-selectivity.test' (around line 124) that covers in-list predicates for all of the other types. Can you add this there? (and could you also add a brief comment for that test case that notes that its testing push down for various types of in-list predicates?) -- To view, visit http://gerrit.cloudera.org:8080/9578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2569a9e1d58f1c58884d58633d46348364888ed7 Gerrit-Change-Number: 9578 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 19:00:11 +0000 Gerrit-HasComments: Yes
