Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 )
Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test: http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test@553 PS1, Line 553: # Decimal InList predicate. > I can't add the column there because the functional alltypes table doesn't Good point. You could still make it work by having that test join alltypes and decimal_tbl, but that's messy. If you just move this to be next to that test (and also add comments on both test cases to make it clear what's going on) that should be fine -- To view, visit http://gerrit.cloudera.org:8080/9578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2569a9e1d58f1c58884d58633d46348364888ed7 Gerrit-Change-Number: 9578 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 19:18:37 +0000 Gerrit-HasComments: Yes
