Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 )
Change subject: IMPALA-5893: Remove old kinit code for Impala 3 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Good riddance. Please have Michael take a look too. http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc@104 PS2, Line 104: // TODO: Remove this flag and the old kerberos code once we remove 'use_krpc' flag. : // (IMPALA-5893) : DEFINE_bool(use_kudu_kinit, true, "If true, Impala will programatically perform kinit " : "by calling into the libkrb5 library using the provided APIs. If false, it will fork " : "off a kinit process. If use_krpc=true, this flag is treated as true regardless of " : "what it's set to."); can't we remove that too? -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Apr 2018 16:17:23 +0000 Gerrit-HasComments: Yes
