Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 )
Change subject: IMPALA-5893: Remove old kinit code for Impala 3 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc File be/src/rpc/rpc-mgr-kerberized-test.cc: http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc@56 PS3, Line 56: ::testing::Values(KERBEROS_ON)); Do we still need this switch ? Can we simplify RpcMgrTestBase to be not templatized ? -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Apr 2018 18:52:08 +0000 Gerrit-HasComments: Yes
