Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 )
Change subject: CDH-65183 Update scripts in benchmark folder to store workload and few minor updates ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py File tests/benchmark/perf_result_datastore.py: http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py@298 PS5, Line 298: insert into workloadmetrics Fix indentation http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py@338 PS5, Line 338: profile = profile.replace('\"', '') Would be good to add a comment explaining why this is happening? The quotes here " break line below, would single quotes work instead? http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@735 PS5, Line 735: if not first_exec_summary: Add comment. Metadata only queries don't contain a summary, this code is to handle that case. Metadata query is for something like "alter table foo recover partitions" http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@1058 PS5, Line 1058: if exec_summaries[0] is None: Same as comment above, please add a comment line explaining what this does. -- To view, visit http://gerrit.cloudera.org:8080/10100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c Gerrit-Change-Number: 10100 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Apr 2018 21:28:37 +0000 Gerrit-HasComments: Yes
