Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 )
Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@735 PS5, Line 735: if not first_exec_summary: > Add comment. Done http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@1058 PS5, Line 1058: if exec_summaries[0] is None: > Same as comment above, please add a comment line explaining what this does. Done -- To view, visit http://gerrit.cloudera.org:8080/10100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c Gerrit-Change-Number: 10100 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Mon, 14 May 2018 23:59:14 +0000 Gerrit-HasComments: Yes