Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/20612/10/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/20612/10/be/src/runtime/runtime-filter-bank.cc@722 PS10, Line 722: t entry_limit = query_stat > Runtime filter is most needed in big scan fragment, which most likely distr Added TestRuntimeFiltersLateRemoteUpdate in ps18 to exercise this code path. http://gerrit.cloudera.org:8080/#/c/20612/17/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/20612/17/be/src/runtime/runtime-filter-bank.cc@753 PS17, Line 753: k> l(entr > Just found out that SetFilter can not be called multiple times. I'll submit Replaced this with DisableBloomFilter in ps18. http://gerrit.cloudera.org:8080/#/c/20612/18/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/20612/18/be/src/runtime/runtime-filter-bank.cc@412 PS18, Line 412: CombinePeerAndLocalUpdates CombinePeerAndLocalUpdates is refactored to cover all possible states that can happen during merge of local_filter and remote_filter. Local aggregation must be complete before calling CombinePeerAndLocalUpdates. -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 18 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Dec 2023 21:15:43 +0000 Gerrit-HasComments: Yes
