Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/20612/18/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20612/18/common/thrift/ImpalaService.thrift@849 PS18, Line 849: // (no change). Defaults to 0.5. Why update this text, but not RUNTIME_FILTER_CARDINALITY_REDUCTION_SCALE or MAX_NUM_FILTERS_AGGREGATED_PER_HOST? http://gerrit.cloudera.org:8080/#/c/20612/18/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/20612/18/common/thrift/Query.thrift@692 PS18, Line 692: 172: optional double runtime_filter_cardinality_reduction_scale = 1.0 Why are we renumbering these rather than moving runtime_filter_cardinality_reduction_scale to the end? I don't think it matters in this case, but seems like a good habit for the times it does. -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 18 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Dec 2023 22:09:57 +0000 Gerrit-HasComments: Yes
