Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/10/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/10/be/src/service/impala-server.h@1829 PS10, Line 1829: int64_t max_per_host_thread_reservation; This shouldn't be int64_t, then stored as INTEGER. Either change it to int32_t, or BIGINT. http://gerrit.cloudera.org:8080/#/c/20770/10/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/10/be/src/service/workload-management.cc@478 PS10, Line 478: "cluster_memory_admitted", _cluster_memory_admitted, "INTEGER")); This should be BIGINT. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Jan 2024 00:01:30 +0000 Gerrit-HasComments: Yes
