Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/20770/11/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/11/be/src/service/workload-management.cc@465 PS11, Line 465: // TODO: start here with a new string transformer, see string_case.cc ToLowerCase will be removed with next patchset http://gerrit.cloudera.org:8080/#/c/20770/11/be/src/util/string-util.h File be/src/util/string-util.h: http://gerrit.cloudera.org:8080/#/c/20770/11/be/src/util/string-util.h@106 PS11, Line 106: static inline void to_snake_case(const std::string in, std::stringstream* out) { Next patchset changes the `const std::string in` parameter to be passed by ref: `const std::string& in` http://gerrit.cloudera.org:8080/#/c/20770/11/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/20770/11/tests/beeswax/impala_beeswax.py@215 PS11, Line 215: result.runtime_profile = self.get_runtime_profile(handle) This change was made because the full query profile is not available until after the query is closed. A run of cluster tests passed. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Jan 2024 22:10:35 +0000 Gerrit-HasComments: Yes
