Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 )
Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54 PS2, Line 54: The maximum length of an identifier is currently 128 characters, enforced by the metastore database. Could you double check this? What's the longest length we can used when using unicode column names? Each Chinese character is encoded into 3 bytes in UTF-8. In such case, is the maximun length for Chinese column names 128/3 = 42 characters, or still 128 characters? http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@60 PS2, Line 60: An identifier must start with an alphanumeric or underscore character Add "except for column names which can start with unicode characters" http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@67 PS2, Line 67: An identifier can contain only ASCII characters. Add "except for column names which can contain unicode characters" http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@124 PS2, Line 124: Impala column names can both contain and start with unicode characters. I think we'd better merge this into the previous items. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 01:24:14 +0000 Gerrit-HasComments: Yes
