pranav.lo...@cloudera.com has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20950 )

Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation
......................................................................


Patch Set 4:

(4 comments)

> Uploaded patch set 4.

http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml
File docs/topics/impala_identifiers.xml:

http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54
PS2, Line 54:         The maximum length of an identifier is currently 128 
characters except for column names which
> Could you double check this? What's the longest length we can used when usi
It's 767 characters for column names, the same is applied in hive.


http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@60
PS2, Line 60: <p>
> Add "except for column names which can start with unicode characters"
Done


http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@67
PS2, Line 67:       <li>
> Add "except for column names which can contain unicode characters"
Done


http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@124
PS2, Line 124:
> I think we'd better merge this into the previous items.
Done



--
To view, visit http://gerrit.cloudera.org:8080/20950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe
Gerrit-Change-Number: 20950
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Jan 2024 06:39:34 +0000
Gerrit-HasComments: Yes

Reply via email to