Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20973 )
Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@55 PS1, Line 55: private List<FileDescriptor> fileDescs_; Put comment that this is always ordered. http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@210 PS1, Line 210: List<FileDescriptor> orderedFds = Lists.newArrayList(fileDescs_); : Collections.sort(orderedFds); Now that fileDescs_ is always sorted, is this still needed? -- To view, visit http://gerrit.cloudera.org:8080/20973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60773965ecbb4d8e659db158f1f0ac76086d5578 Gerrit-Change-Number: 20973 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Jan 2024 18:30:17 +0000 Gerrit-HasComments: Yes
