Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20973 )
Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20973/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20973/2//COMMIT_MSG@25 PS2, Line 25: s Nit: chance. http://gerrit.cloudera.org:8080/#/c/20973/2//COMMIT_MSG@27 PS2, Line 27: With this patch, IcebergScanNode orders its file descriptors based on Could you elaborate why it i beneficial to assign neighbouring partitions to different executors? http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@55 PS1, Line 55: private List<FileDescriptor> fileDescs_; > Put comment that this is always ordered. It is only sorted if the table is partitioned, isn't it? http://gerrit.cloudera.org:8080/#/c/20973/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@210 PS1, Line 210: List<FileDescriptor> orderedFds = Lists.newArrayList(fileDescs_); : Collections.sort(orderedFds); > Now that fileDescs_ is always sorted, is this still needed? It is only sorted if the table is partitioned, isn't it? http://gerrit.cloudera.org:8080/#/c/20973/2/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/20973/2/tests/query_test/test_iceberg.py@1086 PS2, Line 1086: if files_rejected == 0: continue Optional: I find 'continue' to be a bit more difficult to follow than a conditional, especially that there is only one line after it. -- To view, visit http://gerrit.cloudera.org:8080/20973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60773965ecbb4d8e659db158f1f0ac76086d5578 Gerrit-Change-Number: 20973 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jan 2024 12:14:44 +0000 Gerrit-HasComments: Yes
