Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21021 )
Change subject: IMPALA-12796: Add is_footer_only in TFileSplitGeneratorSpec ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21021/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21021/1//COMMIT_MSG@9 PS1, Line 9: failed by wrong row count What is not clear to me is source of the row counts during the errors - did the scanner read memory garbage, or it came from somewhere else? Would it be possible to harden HDFSParquetScanner against errors like this, e.g. with DCHECKs? http://gerrit.cloudera.org:8080/#/c/21021/1/be/src/scheduling/scheduler-test-util.h File be/src/scheduling/scheduler-test-util.h: http://gerrit.cloudera.org:8080/#/c/21021/1/be/src/scheduling/scheduler-test-util.h@206 PS1, Line 206: is_footer_only optional: default false to add less noise to tests? -- To view, visit http://gerrit.cloudera.org:8080/21021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6e3c14debe68cf601131c6594774c8c695923e Gerrit-Change-Number: 21021 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2024 15:05:19 +0000 Gerrit-HasComments: Yes
