Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21021 )
Change subject: IMPALA-12796: Add is_footer_only in TFileSplitGeneratorSpec ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21021/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21021/1//COMMIT_MSG@9 PS1, Line 9: failed by wrong row count > What is not clear to me is source of the row counts during the errors - did Since there is essentially no Planner change for S3 path, my guess is this change in backend is the root cause: https://gerrit.cloudera.org/c/20804/16/be/src/exec/parquet/hdfs-parquet-scanner.cc#452 For each scan range, the new code will loop file_metadata_.row_groups, while the old code just take one entry of file_metadata_.row_groups after calling NextRowGroup(). -- To view, visit http://gerrit.cloudera.org:8080/21021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6e3c14debe68cf601131c6594774c8c695923e Gerrit-Change-Number: 21021 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2024 15:52:03 +0000 Gerrit-HasComments: Yes
