Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 )
Change subject: IMPALA-12602: Unregister queries on idle timeout ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21074/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21074/1/be/src/service/impala-server.cc@2998 PS1, Line 2998: // Save status so we can report it for unregistered queries. We could choose to do this for all queries cancelled in ExpireQueries. I think it makes sense, but that change has more surface error it might affect. Theoretically any query cancelled via ExpireQuery can no longer have results fetched, and the only interaction a client can have is to view the query's EXCEPTION status. That would more clearly delineate that anything in the "waiting to be closed" section of inflight queries is because a client is still fetching completed results (shouldn't see any queries in the EXCEPTION state in that section). -- To view, visit http://gerrit.cloudera.org:8080/21074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacfc285ed3587892c7ec6f7df3b5f71c9e41baf0 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Feb 2024 00:43:32 +0000 Gerrit-HasComments: Yes