Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 )
Change subject: IMPALA-12602: Unregister queries on idle timeout ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21074/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21074/5/be/src/service/impala-server.cc@2880 PS5, Line 2880: expiration_event->query_id, move(preserved_status)); > Your right, it could have been after releasing the session lock. I'll move Done http://gerrit.cloudera.org:8080/#/c/21074/3/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/21074/3/tests/custom_cluster/test_query_expiration.py@140 PS3, Line 140: ed queries always return their exception, s > Yes, I'll update the asserts to test specific queries. Done. Turns out I was mistaken about short_timeout_expire_handle, it was cancelled due to QUERY_TIMEOUT_S so it always return the exception. -- To view, visit http://gerrit.cloudera.org:8080/21074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacfc285ed3587892c7ec6f7df3b5f71c9e41baf0 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 18:44:02 +0000 Gerrit-HasComments: Yes
