Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21059 )
Change subject: IMPALA-12426: QueryStateRecord Refactor ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/21059/12/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/21059/12/be/src/service/query-state-record.h@172 PS12, Line 172: int64_t EstimateSize(const QueryStateRecord* record); > This is from IMPALA-12801 and carried with this patch after rebase. Ah, I missed that earlier. The query log doesn't retain QueryStateExpanded objects, so I don't think so. That's why QueryStateExpanded holds a shared_ptr to QueryStateRecord: so history can share the record with query log and additionally have QueryStateExpanded data that's only used by history. -- To view, visit http://gerrit.cloudera.org:8080/21059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d470db6fea71ec12e43f86e3fd62ed6259c83a Gerrit-Change-Number: 21059 Gerrit-PatchSet: 12 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Feb 2024 18:37:08 +0000 Gerrit-HasComments: Yes
