Hello Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21059 to look at the new patch set (#13). Change subject: IMPALA-12426: QueryStateRecord Refactor ...................................................................... IMPALA-12426: QueryStateRecord Refactor The QueryStateRecord struct is used to store important information about a completed query for the Impala web UI page of recently completed queries. Since significant portions of this struct has data that is also needed in workload management, it has been refactored. The QueryStateRecord struct was a private child struct under the ImpalaServer class. It has now been moved to a top-level struct within the impala namespace. A new struct named QueryStateExpanded has also been created. This struct contains a shared pointer to a QueryStateRecord so the same QueryStateRecord instance can be used by both the web UI and workload management. The QueryStateExpanded struct also contains additional data that is used exclusively by workload management. New ctests have been added to exercise the added comparators. Change-Id: I57d470db6fea71ec12e43f86e3fd62ed6259c83a --- M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/service/CMakeLists.txt M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-http-handler.cc M be/src/service/impala-http-handler.h M be/src/service/impala-server.cc M be/src/service/impala-server.h A be/src/service/query-state-record-test.cc A be/src/service/query-state-record.cc A be/src/service/query-state-record.h M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h M common/thrift/Query.thrift M fe/src/main/java/org/apache/impala/planner/Planner.java 17 files changed, 979 insertions(+), 294 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/21059/13 -- To view, visit http://gerrit.cloudera.org:8080/21059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I57d470db6fea71ec12e43f86e3fd62ed6259c83a Gerrit-Change-Number: 21059 Gerrit-PatchSet: 13 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>