Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Add system.impala_query_live table ...................................................................... Patch Set 28: (7 comments) Just responding to some of the questions, I need to do some updates to address the rest of the feedback. http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.h File be/src/exec/system-table-scanner.h: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.h@24 PS28, Line 24: struct QueryStateExpanded; > Why take this approach instead of importing query-state-record.h? General strategy to keep compile times fast. I don't need to know anything other than the name, so just use a forward declaration. http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.h@318 PS28, Line 318: const std::shared_ptr<QueryStateRecord> base_state_src = nullptr); > Why make this parameter optional? The code in QueryStateRecord assumes bas I updated it to default initialize if it's null. Saves a little thought on the callers end if they don't already have a QueryStateRecord to pass in (which the live query table doesn't). http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.cc File be/src/service/query-state-record.cc: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.cc@204 PS28, Line 204: base_state->num_rows_fetched = exec_state.num_rows_fetched_counter(); > Fixed this in my patch. Good catch! Ack http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@51 PS28, Line 51: public static final String QUERY_LIVE = "impala_query_live"; > Thoughts on making the query live table name a hidden configuration option? I don't see a good reason to, since as you mention it doesn't create any external artifacts. http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java File fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java: http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@59 PS28, Line 59: checkForSupportedFileFormats(); > Can this function call be skipped? We aren't using any complex types. Or I'll look into it, just copied this from other ScanNodes so I didn't look into the details. http://gerrit.cloudera.org:8080/#/c/20762/28/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/28/tests/custom_cluster/test_query_live.py@34 PS28, Line 34: def validate_columns(self, data, result, completed=True): > We should be able to do a little bit of work to the new test/util/workload_ Yes, I'll work on that in the next rebase. http://gerrit.cloudera.org:8080/#/c/20762/28/tests/custom_cluster/test_query_live.py@370 PS28, Line 370: def test_query_live(self, vector): > Please consider adding asserts on the query plan and exec summary in the pr Makes sense. I think I'll add another query too for a bit of variety in what I'm validating. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 28 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Mar 2024 23:16:28 +0000 Gerrit-HasComments: Yes
