Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Add system.impala_query_live table ...................................................................... Patch Set 33: (4 comments) http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.h File be/src/exec/system-table-scanner.h: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.h@24 PS28, Line 24: struct QueryStateExpanded; > General strategy to keep compile times fast. I don't need to know anything Thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/exec/system-table-scanner.cc@147 PS28, Line 147: for (auto event : query.EventsTimeline()) { > I may try to re-use helpers from workload-management.h, or move this logic It would be better in QueryStateExpanded so the complete queries code could take advantage of it. I will look into putting it there. http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/20762/28/be/src/service/query-state-record.h@318 PS28, Line 318: const std::shared_ptr<QueryStateRecord> base_state_src = nullptr); > I updated it to default initialize if it's null. Saves a little thought on Ah, I understand now. I did not realize the live query table does not have a QueryStateRecord. My original comment should have said "QueryStateExpanded assumes base_state_src is not nullptr". After looking at the code again, that comment is not accurate. The code creates a new shared_ptr<QueryStateRecord> if base_state_src is null. Thus, there is no possibility for nullptr related issues. http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/20762/28/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@51 PS28, Line 51: public static final String QUERY_LIVE = "impala_query_live"; > I don't see a good reason to, since as you mention it doesn't create any ex Done -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 33 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 22:20:55 +0000 Gerrit-HasComments: Yes
