Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 )
Change subject: IMPALA-12883: Support updating the charge on an entry in the cache ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/cache-test.cc File be/src/util/cache/cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/cache-test.cc@180 PS3, Line 180: // Updating the charge for the erased element evicts something Why do you call h1 the erased element? http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h File be/src/util/cache/cache.h: http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h@96 PS2, Line 96: // this makes it easier to embed in containers. > Done Ack http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/cache.h@130 PS2, Line 130: // this makes it easier to embed in containers. > Done Ack http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/lirs-cache-test.cc File be/src/util/cache/lirs-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/lirs-cache-test.cc@290 PS3, Line 290: cache_->UpdateCharge(handle, cache_->MaxCharge()); Do you want to validate the handle's charge doesn't change too? http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/21122/2/be/src/util/cache/lirs-cache.cc@975 PS2, Line 975: handle->set_charge(charge); > Fixed this and added some tests Done -- To view, visit http://gerrit.cloudera.org:8080/21122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f54fb3a91a77821651c25d8d3bc3a2a3945025 Gerrit-Change-Number: 21122 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 11 Mar 2024 18:53:35 +0000 Gerrit-HasComments: Yes
