Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21122 )
Change subject: IMPALA-12883: Support updating the charge on an entry in the cache ...................................................................... Patch Set 3: (2 comments) I did one other change in the new upload: charge becomes a size_t in all interfaces (which means kAutomaticCharge is a size_t and set to the max val). That avoids issues about charge being negative, etc. http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/cache-test.cc File be/src/util/cache/cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/cache-test.cc@180 PS3, Line 180: // Updating the charge for the erased element evicts something > Why do you call h1 the erased element? Oops, fixed http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/lirs-cache-test.cc File be/src/util/cache/lirs-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21122/3/be/src/util/cache/lirs-cache-test.cc@290 PS3, Line 290: cache_->UpdateCharge(handle, cache_->MaxCharge()); > Do you want to validate the handle's charge doesn't change too? Added the ability to get the charge for a handle and checked that it doesn't change. -- To view, visit http://gerrit.cloudera.org:8080/21122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f54fb3a91a77821651c25d8d3bc3a2a3945025 Gerrit-Change-Number: 21122 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 17:44:43 +0000 Gerrit-HasComments: Yes
