Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 41: (1 comment) http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py@33 PS41, Line 33: class TestQueryLogTable(CustomClusterTestSuite): : """Tests to assert the query log table is correctly populated.""" : : WM_DB = "sys" : QUERY_TBL = "{0}.impala_query_log".format(WM_DB) : PROTOCOL_BEESWAX = ["beeswax"] : PROTOCOL_HS2 = ["hs2"] : PROTOCOL_ALL = [PROTOCOL_BEESWAX[0], PROTOCOL_HS2[0]] : : @CustomClusterTestSuite.with_args(impalad_args="--enable_workload_mgmt " : "--query_log_write_interval_s=1 " : "--cluster_id=test_max_select " : "--shutdown_grace_period_s=10 " : "--shutdown_deadline_s=60", : catalogd_args="--enable_workload_mgmt", : impalad_graceful_shutdown=True) : @pytest.mark.parametrize("client_protocol", PROTOCOL_BEESWAX) : def test_query_log_table_almost_max_select(self, client_protocol): > Impala test framework use ImpalaTestMatrix to parameterize its test functio Looks like ImpalaTestSuite already has 'protocol' dimension. https://github.com/apache/impala/blob/70c35425d3f8ac68b23fb8e0d08e12ee763965d7/tests/common/impala_test_suite.py#L185 In that case, TestQueryLogTableHS2Client and TestQueryLogTableAllClients can simply override that 'protocol' dimension. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 41 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Mar 2024 22:53:15 +0000 Gerrit-HasComments: Yes
