Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 43: (7 comments) http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/impala-server.h@1285 PS43, Line 1285: typedef std::pair<std::shared_ptr<QueryStateExpanded>, uint8_t> completed_query_entry; nit: can this be a struct instead of pair? http://gerrit.cloudera.org:8080/#/c/20770/41/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/41/be/src/service/workload-management.cc@79 PS41, Line 79: return false; : } : : if (val.find_first_of('"') != string::npos) { : LOG(ERROR) << "Invalid value for --" << name << ": must not contain double quotes."; : return false; : } : : if (val.find_first_of('\n') != string::npos) { : LOG(ERROR) << "Invalid value for --" << name << ": must not contain newlines."; : return false; : } : : return true; : }); : > This parameter gets passed directly to the "LOCATION" portion of the create Done http://gerrit.cloudera.org:8080/#/c/20770/41/be/src/service/workload-management.cc@479 PS41, Line 479: : DCHECK(ImpaladMetrics::COMPLETED_QUERIES_QUEUED->GetValue() >= > Yes, each completed query is tried three times to be inserted into the comp Thank you for the explanation. http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/43/be/src/service/workload-management.cc@470 PS43, Line 470: iter->second += 1; nit: Add comment mentioning that this is an attempt increment. http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py@87 PS41, Line 87: == self.MA > There is not a well defined pattern for custom cluster tests. I like this Done http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py@168 PS41, Line 168: "--shutdown_grace_period_s=10 " : "--shutdown_deadline_s=60", : catalogd_args="--enable_workload_mgmt", : > It possibly could. The test_query_log_table_ddl test is specifically to te In that case, please give distinctive comment for each of them. http://gerrit.cloudera.org:8080/#/c/20770/41/tests/custom_cluster/test_query_log.py@835 PS41, Line 835: > I didn't use named arguments anywhere else, thus I don't want to include it Done -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 43 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 20:15:56 +0000 Gerrit-HasComments: Yes
