Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1785 PS4, Line 1785: skipFileMetadata > nit: "skipFileMetadataReload" sounds better Done http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1792 PS4, Line 1792: if (!(isNonTrivialSdPropsChanged(beforeTable.getSd(), afterTable.getSd()))) { : skipFileMetadata = true; : } else { : skipFileMetadata = false; : } > This means skipFileMetadata = !isNonTrivialSdPropsChanged() regardless of w I'm reverting back to patchset 2's logic of skipping file metadata. Reason being, it is not common to change two different things in the same alter table query. I have tried different combinations of tblproperties/Sd properties/schema change and owner change in the same alter table query and I cannot seem to find the right logic that always works. So I think users would have to set file_metadata_reload="" if two options are changing in single alter table statement. http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1860 PS4, Line 1860: file metadata reload can be skipped > Shouldn't this be "file metadata should be reloaded"? Sorry my bad. http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1873 PS4, Line 1873: table schema reload can be skipped > nit: "file metadata should be reloaded" Ack http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21019/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@a3035 PS4, Line 3035: > Why do we remove existing tests in testAlterTableNoFileMetadataReload()? Good catch. This is not intentional. I'll revert it back. -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2024 00:29:13 +0000 Gerrit-HasComments: Yes
