Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/21019/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21019/6//COMMIT_MSG@14 PS6, Line 14: . The > nit: remove "=true" ? Done http://gerrit.cloudera.org:8080/#/c/21019/6//COMMIT_MSG@15 PS6, Line 15: : > nit: this is stale now Ack http://gerrit.cloudera.org:8080/#/c/21019/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21019/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1936 PS6, Line 1936: "newOwner: {}. So file metadata reload can be skipped.", > nit: let's also add "So file metadata should be reloaded" here. Done http://gerrit.cloudera.org:8080/#/c/21019/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1971 PS6, Line 1971: return false; > So we return false for other unknown cases. In the future if a new field is In the latest patch, I have addressed this comment. Please let me know if that looks good. http://gerrit.cloudera.org:8080/#/c/21019/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21019/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3050 PS6, Line 3050: assertNotEquals(fileMetadataLoadAfter, fileMetadataLoadBefore); > Why do we change this? fileMetadataLoadAfter >= fileMetadataLoadBefore is a issue with reverting back to old code. Will do it properly in the next patch set. -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 05:10:54 +0000 Gerrit-HasComments: Yes
