Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 44: (2 comments) http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/service/impala-server.h@509 PS41, Line 509: /// completed_queries_lock_ to check for completed queries that have not been written. > It's not though. It has to take a lock (which is not marked mutable). Locki I was under the impression that taking a lock could not throw an exception. Withdrawn. http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/service/impala-server.h@1139 PS41, Line 1139: > Do we really want to do that? lock() can throw an exception. We do occasion Only rationale was to use constant as much as possible so other const functions can call this function if needed. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 44 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Mar 2024 17:48:24 +0000 Gerrit-HasComments: Yes
