Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 45: (3 comments) http://gerrit.cloudera.org:8080/#/c/20762/45/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: http://gerrit.cloudera.org:8080/#/c/20762/45/fe/src/main/java/org/apache/impala/service/BackendConfig.java@487 PS45, Line 487: public void setEnableWorkloadMgmt(boolean enableWorkloadMgmt) { nit: Add comment that this is intended for testing only. http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@24 PS41, Line 24: > Since these tests do not change the size of the test clusters, they will al I just realize all 3 impalads are eligible as coordinator. It will be great to have custom cluster test with some of them set as dedicated coordinator (say, cluster_size=3 and num_exclusive_coordinators=2), and confirm that the scan fragment count is equal to number of coordinator. http://gerrit.cloudera.org:8080/#/c/20762/45/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/45/tests/custom_cluster/test_query_live.py@79 PS45, Line 79: result = self.execute_query("select * from sys.impala_query_live") : assert len(result.data) == 2 Consider adding second client to the second impalad and query impala_query_live from there. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 45 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Mar 2024 20:14:21 +0000 Gerrit-HasComments: Yes
