Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 47: (4 comments) http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc@209 PS47, Line 209: int64_t end_time_us Nit: if pushing another patch, please mark const. If not pushing another patch, leave as-is. http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc@210 PS47, Line 210: int64_t duration_us Nit: if pushing another patch, please mark const. If not pushing another patch, leave as-is. http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/service/fe-support.cc@668 PS47, Line 668: server != nullptr Wrap condition with LIKELY since server should only be nullptr when running in tests. http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java@137 PS47, Line 137: is Nit: was? -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 47 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 18:24:55 +0000 Gerrit-HasComments: Yes
