Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 )
Change subject: IMPALA-6948,6962: add end-to-end tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10291/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10291/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-6948,6962: add end-to-end tests best practice is to spell out IMPALA-6962 so various tools can find it http://gerrit.cloudera.org:8080/#/c/10291/1/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/10291/1/tests/common/impala_service.py@132 PS1, Line 132: def get_catalog_objects(self, excludes=['_impala_builtins']): We also had issues with coordinator/impalad metadata coherency because of the 2 code paths. Do we want to extend the comparison to cover that case? Fine to do that later. http://gerrit.cloudera.org:8080/#/c/10291/1/tests/custom_cluster/test_metadata_replicas.py File tests/custom_cluster/test_metadata_replicas.py: http://gerrit.cloudera.org:8080/#/c/10291/1/tests/custom_cluster/test_metadata_replicas.py@42 PS1, Line 42: for obj in c_objects: This is very expensive, do we really need all tables? How long does this test run? -- To view, visit http://gerrit.cloudera.org:8080/10291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c5b39e29b2885cd30fede18833cbf23fb755f5 Gerrit-Change-Number: 10291 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Comment-Date: Thu, 03 May 2018 22:17:26 +0000 Gerrit-HasComments: Yes
