Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 )
Change subject: IMPALA-6948,6962: add end-to-end tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10291/1/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/10291/1/tests/common/impala_service.py@132 PS1, Line 132: def get_catalog_objects(self, excludes=['_impala_builtins']): > We also had issues with coordinator/impalad metadata coherency because of t currently, I just grab the version so it wouldn't cover the case you're referring to. the objects come out as thrift->html or as json with the thrift as a debug string so I'd want to make a better api. but yes, would be good to cover those cases. http://gerrit.cloudera.org:8080/#/c/10291/1/tests/custom_cluster/test_metadata_replicas.py File tests/custom_cluster/test_metadata_replicas.py: http://gerrit.cloudera.org:8080/#/c/10291/1/tests/custom_cluster/test_metadata_replicas.py@42 PS1, Line 42: for obj in c_objects: > This is very expensive, do we really need all tables? How long does this te L42-47 takes ~7-8 s. validation on L49 takes ~2-3 s. total test takes ~19 s (starting/stopping cluster, etc). For simplicity, I look at all objects. I can whitelist both steps if this is too expensive. -- To view, visit http://gerrit.cloudera.org:8080/10291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c5b39e29b2885cd30fede18833cbf23fb755f5 Gerrit-Change-Number: 10291 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 04 May 2018 00:59:21 +0000 Gerrit-HasComments: Yes
