Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 )
Change subject: IMPALA-12602: Unregister queries on idle timeout ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21074/9/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21074/9/be/src/service/impala-server.cc@2879 PS9, Line 2879: > Is there any test where preserved_status.ok() == false? Maybe test query wi Hmm. So far I can't find a way to cause there to be an exception without unregistering the query. Maybe there's no point preserving these messages because they'll always be "Query ... expired due to client inactivity". http://gerrit.cloudera.org:8080/#/c/21074/9/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/21074/9/tests/custom_cluster/test_query_expiration.py@144 PS9, Line 144: assert ' expired due to ' in str(e) > Yes, that's what should be happening. Only expiration due to idle timeout i Done -- To view, visit http://gerrit.cloudera.org:8080/21074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacfc285ed3587892c7ec6f7df3b5f71c9e41baf0 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Apr 2024 23:04:32 +0000 Gerrit-HasComments: Yes
