Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21074 )
Change subject: IMPALA-12602: Unregister queries on idle timeout ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/21074/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21074/3//COMMIT_MSG@13 PS3, Line 13: Adds a new structure - idle_query_statuses_ - to retain Status messages : for queries closed this way so that we can continue to return a clear : error message if the client returns and requests query status or : attempts to fetch results. This structure must be global because HS2 : server can only identify a session ID from a query handle, and the quer > Some brain dump about this topic, I don't mean to change anything in this r That could also be a reasonable way to do this. It'd be a more involved change to GetActiveQueryHandle. http://gerrit.cloudera.org:8080/#/c/21074/7/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21074/7/be/src/service/impala-server.h@181 PS7, Line 181: /// This class is partially thread-safe. To ensure freedom from deadlock, if multiple > Can you add idle_query_statuses_lock_ to this list? Done http://gerrit.cloudera.org:8080/#/c/21074/7/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21074/7/be/src/service/impala-server.cc@1439 PS7, Line 1439: ImpaladMetri > nit: can be static inline? Done http://gerrit.cloudera.org:8080/#/c/21074/7/be/src/service/impala-server.cc@2863 PS7, Line 2863: > nit: mark const We basically never do that. Status is a essentially a scalar type. But I suppose it doesn't hurt. http://gerrit.cloudera.org:8080/#/c/21074/7/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: http://gerrit.cloudera.org:8080/#/c/21074/7/docs/topics/impala_timeouts.xml@130 PS7, Line 130: exception details. > Please add an explanation that the status will be INACTIVE_QUERY_EXPIRED if Done -- To view, visit http://gerrit.cloudera.org:8080/21074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacfc285ed3587892c7ec6f7df3b5f71c9e41baf0 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 04:47:08 +0000 Gerrit-HasComments: Yes
