Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 )
Change subject: IMPALA-6946: handle negative counts in RLE decoder ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10233/4/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: http://gerrit.cloudera.org:8080/#/c/10233/4/be/src/util/rle-encoding.h@606 PS4, Line 606: vlq > nit: uleb Done http://gerrit.cloudera.org:8080/#/c/10233/4/be/src/util/rle-encoding.h@625 PS4, Line 625: DCHECK_LE(run_len, std::numeric_limits<int32_t>::max()) > Can this go to L615, right after reading run_len? If not, can you add a com It's valid up there too. My thought process ws that this was the location where we depend on the DCHECK, but I think it probably makes more sense to put it as early as possible http://gerrit.cloudera.org:8080/#/c/10233/4/be/src/util/rle-test.cc File be/src/util/rle-test.cc: http://gerrit.cloudera.org:8080/#/c/10233/4/be/src/util/rle-test.cc@514 PS4, Line 514: // IMPALA-6946 hit DCHECK because it treated -1 as a signed integer. > I don't understand how the comment relates to the next two lines. Can you c Done -- To view, visit http://gerrit.cloudera.org:8080/10233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If75ef3fb12494209918c100f26407cd93b17addb Gerrit-Change-Number: 10233 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 04 May 2018 20:23:46 +0000 Gerrit-HasComments: Yes
