Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 )
Change subject: IMPALA-6946: handle negative counts in RLE decoder ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10233/5/be/src/util/rle-test.cc File be/src/util/rle-test.cc: http://gerrit.cloudera.org:8080/#/c/10233/5/be/src/util/rle-test.cc@517 PS5, Line 517: decoder.GetValues(1, &val); > This looks to me like we're reading from a partially initialized buffer. We Good point. The buffer is zero-initialised so we'd expect it to return all-zeros if anything. Updated to reflect expected behaviour -- To view, visit http://gerrit.cloudera.org:8080/10233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If75ef3fb12494209918c100f26407cd93b17addb Gerrit-Change-Number: 10233 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 16:43:52 +0000 Gerrit-HasComments: Yes
