Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 )
Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21258/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21258/4//COMMIT_MSG@13 PS4, Line 13: IcebergDeleteBuilder now also tolerates NULL file paths Is it possible to add a test for this? http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.h File be/src/exec/iceberg-delete-builder.h: http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.h@79 PS4, Line 79: /// Partitioned: Both data and delete files are hashed by the file path. This means Shouldn't we mention DIRECTED mode here? http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.cc@272 PS4, Line 272: state Do we use 'state' anywhere? If not, this parameter could also be removed from AddBatch(). -- To view, visit http://gerrit.cloudera.org:8080/21258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba02b33433990950b49628f11e732e01ed8a34d Gerrit-Change-Number: 21258 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 14:31:45 +0000 Gerrit-HasComments: Yes