Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 )
Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder ...................................................................... Patch Set 7: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21258/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21258/2//COMMIT_MSG@13 PS2, Line 13: IcebergDeleteBuilder and KrpcDataStreamSender now also tolerate > It is not valid, but we have seen such errors at certain customers. Unfortu Actually there are still cases then the IcebergDeleteBuilder receives NULL file paths, e.g. num_nodes=1, or there's only a single data file http://gerrit.cloudera.org:8080/#/c/21258/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21258/4//COMMIT_MSG@13 PS4, Line 13: IcebergDeleteBuilder and KrpcDataStreamSender now also > Is it possible to add a test for this? Yeah I've just added tests http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.h File be/src/exec/iceberg-delete-builder.h: http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.h@79 PS4, Line 79: /// Shared Build > Shouldn't we mention DIRECTED mode here? Actually we should only mention the DIRECTED mode, since this is the only supported mode. http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21258/4/be/src/exec/iceberg-delete-builder.cc@272 PS4, Line 272: state > Do we use 'state' anywhere? If not, this parameter could also be removed fr In PS5 we use again -- To view, visit http://gerrit.cloudera.org:8080/21258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba02b33433990950b49628f11e732e01ed8a34d Gerrit-Change-Number: 21258 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 16:32:44 +0000 Gerrit-HasComments: Yes