Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 )
Change subject: test-with-docker: exit properly on failures ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10318/1/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/10318/1/docker/entrypoint.sh@381 PS1, Line 381: # The "| cat" here avoids "set -e"/errexit from exiting the : # script right away. : "${CMD}" "$@" | cat : ret=${PIPESTATUS[0]} Let me double-check my understanding: The "set -e" didn't work with the CMD inside an if. When it is not inside the if, "set -e" does what we want and causes the CMD function to exit if any command in the function evaluates false. However, we don't want it exiting main() at that point, hence the cat + PIPESTATUS. Is this right? -- To view, visit http://gerrit.cloudera.org:8080/10318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I285e2f4d07e34898d73beba857e9ac325ed4e6db Gerrit-Change-Number: 10318 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 18:37:51 +0000 Gerrit-HasComments: Yes
