Philip Zeyliger has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/10318 )
Change subject: test-with-docker: exit properly on failures
......................................................................
test-with-docker: exit properly on failures
If the build was failing, test-with-docker wouldn't recognize
it and continue with the script; this fixes that.
The bash puzzle I learned here is that
bash -c "set -e; function f() { false; echo f; }; if f; then echo x; fi"
will print "f" and "x", despite the set -e, even if f is put into
a sub-shell with parentheses.
Change-Id: I285e2f4d07e34898d73beba857e9ac325ed4e6db
Reviewed-on: http://gerrit.cloudera.org:8080/10318
Tested-by: Philip Zeyliger <phi...@cloudera.com>
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>
---
M docker/entrypoint.sh
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Philip Zeyliger: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I285e2f4d07e34898d73beba857e9ac325ed4e6db
Gerrit-Change-Number: 10318
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
