Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 )
Change subject: IMPALA-13000: Document OPTIMIZE TABLE ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@553 PS1, Line 553: in nit: maybe 'on'? http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@554 PS1, Line 554: update files There are no such files as 'udpdate files', so I'd just use 'data files' http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@565 PS1, Line 565: <li>rewrite files using the latest table schema</li> : <li>rewrite partitions according to the latest partition spec</li> I would slightly phrase it differently, as the current phrasing might suggest that data files with old schema/partition spec are getting selected for rewrite. So maybe: "the newly written files will have the latest schema and partitioned based on the latest partition spec" http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@577 PS1, Line 577: <li>Views cannot be optimized.</li> not sure if we need this as this should be clear http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@583 PS1, Line 583: . "..., because the rewritten data and delete files are not removed physically." -- To view, visit http://gerrit.cloudera.org:8080/21320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851669686ed4da610dcac97c9b88ff23b0a4a647 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Apr 2024 13:33:08 +0000 Gerrit-HasComments: Yes
