Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 )
Change subject: IMPALA-13000: Document OPTIMIZE TABLE ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/21320/1/docs/topics/impala_iceberg.xml@556 PS1, Line 556: able_na > [] is quite standard notation, and we are using it extensively in the Impal I'm also okay with leaving [db_name]. I think a separate top-level page or even just a paragraph showing the proper syntax would be even better. http://gerrit.cloudera.org:8080/#/c/21320/2/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/21320/2/docs/topics/impala_iceberg.xml@566 PS2, Line 566: using If you want to make it even clearer that all files are rewritten (not just the ones with the latest schema), you could write "rewrite all files, converting them (if necessary) to the latest table schema". I'm not sure it's needed, I'm also okay with the current wording. -- To view, visit http://gerrit.cloudera.org:8080/21320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851669686ed4da610dcac97c9b88ff23b0a4a647 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 13:20:58 +0000 Gerrit-HasComments: Yes