Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21302/2/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21302/2/be/src/service/workload-management.cc@116 PS2, Line 116: field.db_column > Is this the reason why TQueryTableColumn values all changed to lowercase? Yes, that's why I changed them. I guess I can do that instead. According to https://impala.apache.org/docs/build/html/topics/impala_identifiers.html, IDs are case-insensitive and converted to lower-case internally, so I can probably let this be uppercase and the only thing affected will be logs. http://gerrit.cloudera.org:8080/#/c/21302/2/common/thrift/SystemTables.thrift File common/thrift/SystemTables.thrift: http://gerrit.cloudera.org:8080/#/c/21302/2/common/thrift/SystemTables.thrift@23 PS2, Line 23: cluster_id = 0 : query_id > Assign ordinal number for other values? Just going to go back to unassigned. There's a DCHECK that asserts these are sequential starting from 0. http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java File fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java: http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java@25 PS2, Line 25: * TableRef class for system tables. > Comment what can and can not be done with SystemTableRef, such as "COMPUTE Ack http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@59 PS2, Line 59: public static final String TBL_PROP_SYSTEM_TABLE = "__IMPALA_SYSTEM_TABLE"; > Do we have common place to put all table properties that only understood by I don't think so. I was looking at DataSourceTable for this pattern. -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Apr 2024 20:16:09 +0000 Gerrit-HasComments: Yes
