Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21302/4/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21302/4/be/src/service/workload-management.cc@300 PS4, Line 300: field.db_column This need lowercase as well? http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java File fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java: http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/analysis/SystemTableRef.java@28 PS4, Line 28: Currently COMPUTE STATS does not work on these tables. Question: is UPDATE/DELETE/TRUNCATE allowed for SystemTable? http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@59 PS4, Line 59: public static final String TBL_PROP_SYSTEM_TABLE = "__IMPALA_SYSTEM_TABLE"; I think it is time we should organize all impala-specific table properties into one place, say, as a list of string constant in CatalogObjects.thrift. Is it the first time we have table property key referred both in FE and BE code? Currently, they are scattered around FE source code like FeTable.java and others: $ git grep -n "static.* TBL_PROP_" | cat fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java:42: public static final String TBL_PROP_SORT_COLUMNS = "sort.columns"; fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java:43: public static final String TBL_PROP_SORT_ORDER = "sort.order"; fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:64: public static final String TBL_PROP_DATA_SRC_NAME = "__IMPALA_DATA_SOURCE_NAME"; fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:69: public static final String TBL_PROP_INIT_STRING = "__IMPALA_DATA_SOURCE_INIT_STRING"; fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:74: public static final String TBL_PROP_LOCATION = "__IMPALA_DATA_SOURCE_LOCATION"; fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:79: public static final String TBL_PROP_CLASS = "__IMPALA_DATA_SOURCE_CLASS"; fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:84: public static final String TBL_PROP_API_VER = "__IMPALA_DATA_SOURCE_API_VERSION"; fe/src/main/java/org/apache/impala/catalog/FeFsTable.java:381: public static final String TBL_PROP_SKIP_HEADER_LINE_COUNT = "skip.header.line.count"; fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:168: public static final String TBL_PROP_ENABLE_STATS_EXTRAPOLATION = fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:175: public static final String TBL_PROP_DISABLE_RECURSIVE_LISTING = fe/src/main/java/org/apache/impala/catalog/Table.java:188: public static final String TBL_PROP_LAST_DDL_TIME = "transient_lastDdlTime"; fe/src/main/java/org/apache/impala/catalog/Table.java:191: public static final String TBL_PROP_LAST_COMPUTE_STATS_TIME = fe/src/main/java/org/apache/impala/catalog/Table.java:195: public static final String TBL_PROP_EXTERNAL_TABLE = "EXTERNAL"; fe/src/main/java/org/apache/impala/catalog/Table.java:198: public static final String TBL_PROP_EXTERNAL_TABLE_PURGE = "external.table.purge"; fe/src/main/java/org/apache/impala/catalog/Table.java:199: public static final String TBL_PROP_EXTERNAL_TABLE_PURGE_DEFAULT = "TRUE"; Going forward, I wish we can have standard prefix for impala-specific table property key, either "impala.*" or "__IMPALA_*". I wonder what is Quanlong and Wenzhe's opinion on this. -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 15:53:40 +0000 Gerrit-HasComments: Yes
