Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/10060/7/be/src/service/client-request-state.cc@734 PS7, Line 734: : && TOperationState::INITIALIZED_STATE < operation_state) Ahh I missed that this was implied by the DCHECK on my first pass. I think this code would be easier to understand if it didn't try to be cute with the inequality of enums. I couldn't understand this code without pulling up TCLIService.thrift and looking at them side-by-side, which is a bad sign. Can we just make the valid state transitions explicit? I don't think there are actually that many distinct transitions to consider. Maybe something like: switch (operation_state_) { case INITIALIZED_STATE: case PENDING_STATE: UpdateOperationState(); break; case RUNNING_STATE: if (operation_state == FINISHED_STATE) UpdateOperationState(); break; default: // .. break; } http://gerrit.cloudera.org:8080/#/c/10060/7/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/10060/7/tests/hs2/test_hs2.py@468 PS7, Line 468: # ExecSummary. We should also test getting the exec summary after the query was admitted but before it was closed. -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 7 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 21:13:53 +0000 Gerrit-HasComments: Yes
